Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong comment on Proxy guide #2447

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Fix wrong comment on Proxy guide #2447

merged 1 commit into from
Jun 18, 2017

Conversation

hellowin
Copy link
Contributor

@hellowin hellowin commented Jun 1, 2017

It should be baz instead of bar on last example.

    // Matches /bar/abc.html and /bar/sub/def.html <- wrong
    "/baz/**/*.html": {
      "target": "<url_4>"
      // ...
    }

@hellowin
Fix wrong comment on Proxy guide
f439176 
It should be `baz` instead of `bar` on last example.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Jun 18, 2017

Nice catch, thanks!

@Timer Timer added this to the 1.0.8 milestone Jun 18, 2017
@Timer Timer merged commit 2ab7ead into facebook:master Jun 18, 2017
laurililja pushed a commit to laurililja/create-react-app that referenced this pull request Jun 27, 2017
@hellowin @laurililja
Fix wrong comment on Proxy guide (facebook#2447)
53a3055 
It should be `baz` instead of `bar` on last example.
@gaearon gaearon mentioned this pull request Jun 28, 2017
Merged
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@hellowin @romaindso
Fix wrong comment on Proxy guide (facebook#2447)
c41646c 
It should be `baz` instead of `bar` on last example.
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@hellowin @wmonk
Fix wrong comment on Proxy guide (#2447)
4aa42e2 
It should be `baz` instead of `bar` on last example.
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
@hellowin hellowin deleted the fix-wrong-comment-proxy branch May 13, 2023 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
1.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@hellowin @facebook-github-bot @Timer